Comments on: jQuery Ratings – A Progressive Enhancement Approach

By: Kyle

Kyle — Fri, 29 Aug 2008 13:02:26 +0000

Great catch Andras, In my haste before my presentation I focused on the label click event instead of the radio button click event.

Since clicking a label will toggle the associated input it was doubling up the request. Fixed now!

http://kylebradshaw.com/presentations/jQuery/rating.html

By: Andras

Andras — Fri, 29 Aug 2008 12:26:27 +0000

Hello,

One question: debugging with firebug its seems that it calls results.php twice ?

http://kylebradshaw.com/presentations/jQuery/rating.html

Andras

By: Jason

Jason — Mon, 31 Mar 2008 19:09:05 +0000

I forgot to mention in my previous post a solution to the problem I highlighted. The CSS declarations display:none and visibility:hidden will prohibit form elements from receiving focus, and as jQuery's hide() method uses display:none (I believe), this is out. However, one can use position:absolute; and z-index:-1; to place the form element behind its label effectively hiding it. To save our graceful degradation, these CSS declarations would best be applied using a class that is added to the elements via JS. Otherwise, the form elements would be hidden in the JS-off, CSS-on scenario.

By: Jason

Jason — Mon, 31 Mar 2008 18:49:01 +0000

Although I like the approach and the concept is great, the implementation leaves much to be desired. This solution is inaccessible to users who are unable to use a mouse, as the labels do not receive focus by tabbing. (Tested in Fx 2 and 3b4, IE7)

By: Kyle

Kyle — Mon, 24 Mar 2008 16:09:06 +0000

Great point Steve!

Use of the element would definitely improve the markup. I'll have to roll that in!

By: steve

steve — Mon, 24 Mar 2008 14:55:19 +0000

Nice!

My only suggestion would be the addition of a legend element on the form for the "rate" text that you would then enhance via CSS to prettify it to what you've got now.